chore: 100% test coverage for SQL parsing #33568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
github-actions
bot
added
the
github_actions
betodealmeida
force-pushed
the
sqlglot-tests
branch
2 times, most recently
from
9307e30 to
e151a54
Compare
betodealmeida
force-pushed
the
sqlglot-tests
branch
from
e151a54 to
cf5c8ac
Compare
betodealmeida
force-pushed
the
remove-sql_parse
branch
10 times, most recently
from
094e4b9 to
eefc631
Compare
betodealmeida
force-pushed
the
sqlglot-tests
branch
2 times, most recently
from
9d654ac to
b1830b2
Compare
betodealmeida
requested review from
eschutho,
geido,
mistercrunch,
nytai,
rusackas and
villebro
as code owners
betodealmeida
commented
May 30, 2025
| target = statements[-1] | ||
| for node in statements[-1].walk(): | ||
| if hasattr(node, "comments"): | ||
| if hasattr(node, "comments"): # pragma: no cover |
Member
Author
There was a problem hiding this comment.
There were a couple lines that I couldn't hit with tests, but I thought it was safer to keep them, so I added the pragma.
betodealmeida
commented
May 30, 2025
| rendered_template = Template(template).render(processor.get_context()) | ||
| code = processor.env.compile(ast) | ||
| template = Template.from_code(processor.env, code, globals=processor.env.globals) | ||
| rendered_sql = template.render(processor.get_context()) |
Member
|
|
betodealmeida
force-pushed
the
remove-sql_parse
branch
from
eefc631 to
dcd9140
Compare
betodealmeida
force-pushed
the
remove-sql_parse
branch
6 times, most recently
from
4834814 to
1c2fee5
Compare
betodealmeida
force-pushed
the
sqlglot-tests
branch
2 times, most recently
from
789c101 to
7be3f1b
Compare
betodealmeida
force-pushed
the
remove-sql_parse
branch
from
1c2fee5 to
a015ab1
Compare
Member
next on my wish list -> |
betodealmeida
force-pushed
the
sqlglot-tests
branch
from
7be3f1b to
2032f8c
Compare
eschutho
approved these changes
Jun 5, 2025
ianngech
pushed a commit
to Pesapal-Ltd/superset
that referenced
this pull request
Jun 10, 2025
LevisNgigi
pushed a commit
to LevisNgigi/superset
that referenced
this pull request
Jun 18, 2025
github-actions
bot
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part of SIP-117, stacked on:
Adds 100% unit tests coverage to the
superset/sql/directory, and a CI rule to enforce it.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION